?Had a new starter and new battery put on my 1999 Chevy Tahoe.. we by it starts sometimes and sometime it don't..what could the problem be

I'm assuming just by the fact you had a new battery and new starter that sometimes when you turn the key to the start position , nothing happens . Is your vehicle a automatic transmission ? When it doesn't start have checked for battery voltage at the starter solenoid S terminal ? Is there B+ voltage at pins 30 & 86 for the starter relay ? Pin 86 while cranking the engine or trying to crank the engine over . Pin 30 check with key on . Try moving gear selector to neutral . Videos on youtube for basic automotive electrical testing . How to voltage drop test starter motor circuit Find a wiring diagram at www.bbbind.com
Starting System Circuit Description
Voltage is applied at all times to the ignition switch from the IGN A fuse 6 through CKT 242 (RED). When the ignition switch is turned to the START position, voltage is applied to the CRANK fuse 8 through CKT 5 (YEL). From the CRANK fuse 8, voltage is either applied to the clutch pedal position switch (M/T) or the transmission range switch (A/T) through CKT 806 (PPL). When either the clutch is disengaged (M/T) or the transmission is in park or neutral (A/T), voltage is applied to the coil of the starter relay through CKT 1035 (PPL/WHT). Since the starter relay is permanently grounded at ground G105 through CKT 150 (BLK), the starter relay energizes.
Voltage is applied at all times to the starter relay contacts from IGN A fuse 6 through CKT 242 (RED). When the starter relay energizes, the starter relay contacts close, and voltage is applied to the starter motor solenoid. Since the starter motor solenoid is permanently case grounded, the starter motor solenoid will energize two coils. The pull-in winding coil energizes in order to pull the starter motor solenoid contacts closed. When the contacts close, a plunger on the contacts causes the pull-in winding coil circuit to open. The hold-in winding coil then holds the starter motor solenoid contacts closed. Voltage is then applied to the starter motor from the battery through CKT 1 (BLK) and the closed contacts of the starter motor solenoid. Since the starter motor is also permanently case grounded, the starter motor will run until the ignition switch is moved out of the START position. When this happens, a spring in the starter motor solenoid moves the starter motor solenoid contacts and the plunger back to the rest position.