New battery van would click then started one day and starter would not shut off got new starter fine for two days then does same thing and started smoking what is causing this

If there is a relay in the starter circuit, that is suspect
I would remove the starter motor and check 2 things
first is the condition of the teeth on the ring gear
they have a habit of burring over and the pinion gear gets stuck and will not disengage
next is to check is the pinion teeth the right number on the new starter for the ring gear
That is sometimes an issue but I would suspect first a relay , next damaged teeth on the ring gear ( they appear at specific places on the ring gear (90 degrees -120degres and 180 degrees and run for around 6 teeth where the starter initially engages the ring gear
the smoking is from a burnt out starter because when it is stuck in the ring gear , the starter becomes a generator with uncontrolled current generated going straight to ground