1999 800vs replaced battery when key is turned on to start bike all lights on speedometer light up should be just green neutral.bike just clicks will not turnover

Actually when the key is turned on all the "dash" lights come on neutral, oil, temp and what ever else as soon as the bike starts the lights will go out. If the lights come on while the engine is running then you have a problem or it's in neutral "green".

For the bike not starting a few things, first off the battery even though you say it's new may have been sitting on the shelf for a while and they do loose power so it may need charging. The newer bikes the headlight light comes on when the key is turned on which robs the starting system of power to turn the starter, the batteries need to be good on these bikes or it's just not going to work. If the headlight comes on and looks yellow or amber then there isn't enough power in the battery. If it's a nice bright white light then there is power and the starter may need to be serviced.

If the bike has been sitting over the winter I'd guess the battery has just lost power and requires charging.

Cheers be safe and have fun with your motorcycle